[Core] Add bundle_label_selector scheduling logic#52988
Merged
edoakes merged 12 commits intoray-project:masterfrom May 30, 2025
Merged
[Core] Add bundle_label_selector scheduling logic#52988edoakes merged 12 commits intoray-project:masterfrom
edoakes merged 12 commits intoray-project:masterfrom
Conversation
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
35 tasks
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
mascharkh
added
docs
Contributor
|
@dayshah or @israbbani Do you mind take a brief look from c++'s perspective to see if there is any c++ particular comments? Thanks! |
dayshah
approved these changes
May 25, 2025
Contributor
There was a problem hiding this comment.
one minor cpp nit, otherwise lgtm from cpp perspective. +1 on @MengjinYan comments
Co-authored-by: Dhyey Shah <dhyey2019@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
dayshah
reviewed
May 28, 2025
Co-authored-by: Dhyey Shah <dhyey2019@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
MengjinYan
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds the
bundle_label_selectoroption to Ray PlacementGroups, applying the label selectors on a per-bundle level to define label constraints for scheduling bundles on a node.This PR passes the
bundle_label_selectorfrom thePlacementGroupoptions to the Raylet where thePlacementGroupSpecis built. InsidePlacementGroupSpec, each label selector is added to its correspondingBundlemessage, and then added to theResourceRequestinComputeResourceswhen theBundleSpecis constructed. This enables the cluster resource scheduler to check for required labels when callingIsFeasibleandIsAvailableon a Node.Related issue number
#51564
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.